Add Xiaomi Airfresh VA2 support #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 10, 2018
miio/airfresh.py
Outdated
| @@ -0,0 +1,293 @@ | |||
| import enum | |||
| import logging | |||
| import re | |||
rytilahti
approved these changes
Aug 10, 2018
miio/airfresh.py
Outdated
| try: | ||
| return LedBrightness(self.data["led_level"]) | ||
| except ValueError: | ||
| return None |
There was a problem hiding this comment.
Would it be a good idea to log the error here?
| @property | ||
| def child_lock(self) -> bool: | ||
| """Return True if child lock is on.""" | ||
| return self.data["child_lock"] == "on" |
There was a problem hiding this comment.
Should this and the other properties also be protected against None?
There was a problem hiding this comment.
This property is always available and doesn't need to be safeguarded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cp. syssi/xiaomi_airpurifier#25